Skip to content

Conversation

@Spikhalskiy
Copy link
Contributor

This PR addresses #5791 and opens back up constructors that were ?unintentionally? closed in #5349.
This allows users to decorate or extend the functionality of built-in providers without fully copy-pasting the implementations into user projects.

@Spikhalskiy Spikhalskiy force-pushed the param-converters-constructor branch from e5dbbba to 312b401 Compare November 7, 2024 23:18
@senivam
Copy link
Contributor

senivam commented Nov 8, 2024

could you please make those constructors protected (it should be enough for extending) and sign ECA (as described at our Wiki) for the PR could be merged.

@Spikhalskiy Spikhalskiy force-pushed the param-converters-constructor branch from 312b401 to 5784b64 Compare November 8, 2024 14:26
@Spikhalskiy
Copy link
Contributor Author

Spikhalskiy commented Nov 8, 2024

@senivam I made them protected and I also added a protected no-op constructor to OptionalProvider to have them all consistent.
I already signed the ECA and the account email matches my github and commit email, but the check wasn't turning green. It looks like it did now after a force-push.
Thank you for the review!

@senivam senivam linked an issue Nov 8, 2024 that may be closed by this pull request
@Spikhalskiy Spikhalskiy force-pushed the param-converters-constructor branch from 5784b64 to 6021e7b Compare November 8, 2024 16:53
@Spikhalskiy Spikhalskiy changed the title ParamConverterProvider constructors are now public ParamConverterProvider constructors are now protected to allow extensibility Nov 8, 2024
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senivam senivam merged commit 0f477df into eclipse-ee4j:2.x Nov 12, 2024
7 checks passed
@senivam senivam added this to the 2.46 milestone Nov 12, 2024
@Spikhalskiy Spikhalskiy deleted the param-converters-constructor branch November 16, 2024 15:14
@Spikhalskiy Spikhalskiy changed the title ParamConverterProvider constructors are now protected to allow extensibility [2.x] ParamConverterProvider constructors are now protected to allow extensibility Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jersey 2: Relax ParamConverters constructor visibility to public

3 participants