Micrometer - Add missing metrics for cases of client errors #5592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaste
changed the title
adpaste
force-pushed
the
jersey-client-errors
branch
from
d67dc74 to
9bf5b5d
Compare
Contributor
|
Thank you for the PR. Will the #5531 be fixed either? |
Contributor
Author
|
No problem! #5531 is a different issue. |
Changes ported from micrometer-metrics: micrometer-metrics/micrometer#4326
adpaste
force-pushed
the
jersey-client-errors
branch
from
9bf5b5d to
854305b
Compare
Contributor
yes, I'm just reminding in order not to forget about it :) |
senivam
added
the
micrometer
jansupol
approved these changes
Apr 22, 2024
senivam
approved these changes
Apr 22, 2024
This was referenced May 3, 2024
1 task
This was referenced May 24, 2024
Closed
1 task
1 task
|
Any chance for this fix to be ported to the 3.x version as well? We are actually seeing NullPointerExceptions caused by matchingPattern being null when making a request to a non-existing URL. |
Contributor
|
@andersflemmen it should already be there, all fixes in the 2.x are later uptaken by 3.0, 3.1 etc. |
1 task
This was referenced May 26, 2025
1 task
This was referenced Oct 5, 2025
This was referenced Oct 12, 2025
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes ported from micrometer-metrics/micrometer#4326