Skip to content

Conversation

@jbescos
Copy link
Member

@jbescos jbescos commented Aug 29, 2022

I was not able to reproduce it, but it looks some users are having issues with a couple of tests.

@jansupol it would be good if you can run both tests and provide me feedback about the results.

@jbescos jbescos force-pushed the testInconsistency branch from f1a3963 to cee2185 Compare August 31, 2022 06:12
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static org.junit.Assert.assertEquals;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest version of the PR there are many redundant imports. Could you please clean them out?

And those imports, which are already in place (before any changes) should not be reformatted because when it comes to merges, reformatting brings unnecessary conflicts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see notes in the code

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@senivam senivam merged commit fc63a05 into eclipse-ee4j:master Sep 5, 2022
@senivam senivam added this to the 2.37 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants