Fix regression on LoggingFeature's max entity size #5007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs from outbound streams do not contain '...more...' on trimmed entities.
jansupol
approved these changes
Mar 18, 2022
Contributor
jansupol
left a comment
jansupol
left a comment
There was a problem hiding this comment.
LGTM, baos.write(ba, off, len) does all the checks for len and off
senivam
approved these changes
Mar 18, 2022
nunomsantos
deleted the
fix-regression-on-loggingfeature-max-entity-size
branch
This was referenced Jun 14, 2022
Closed
1 task
This was referenced Jun 18, 2022
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Jan 16, 2024
1 task
1 task
This was referenced Apr 13, 2024
Closed
1 task
This was referenced Feb 23, 2025
This was referenced May 26, 2025
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
PR #4531 implemented the performance improvement requested on #4522 but introduced a regression related to the max entity size property of
LoggingFeature.After it, logs from outbound streams are not appended with "...more..." when their entity is trimmed.
The reason is that we were stopping writes to a
ByteArrayOutputStreamtoo early, so we would never know if it was written in excess.This looks like a sufficient fix, let me know if you can think of other edge cases.