Bug Report: CDI tries to instantiate interface (Jersey 2.30)

[jbescos]

#4781

[senivam]

isn't it better to put FINE/FINER level output?

[jbescos]

isn't it better to put FINE/FINER level output?

I thought it is too much to move from WARNING to FINE, but I am okay doing that.

[senivam]

LGTM

[senivam]

actually 1 change is required:

the main IF here checks if resource is acceptable. Whis includes:

 ((c.getModifiers() & Modifier.ABSTRACT) != 0
                         || c.isPrimitive()
                         || c.isAnnotation()
                         || c.isInterface()
                         || c.isLocalClass()
                         || (c.isMemberClass() && (c.getModifiers() & Modifier.STATIC) == 0));

however as per the issue description this warning output is not applicable only to interface.
So, it would be appropriate to write

LOGGER.log( clazz.isInterface() ? Level.FINE : Level.WARNING,
                    LocalizationMessages.CDI_NON_INSTANTIABLE_COMPONENT(clazz));

[jbescos]

actually 1 change is required:

the main IF here checks if resource is acceptable. Whis includes:

 ((c.getModifiers() & Modifier.ABSTRACT) != 0
                         || c.isPrimitive()
                         || c.isAnnotation()
                         || c.isInterface()
                         || c.isLocalClass()
                         || (c.isMemberClass() && (c.getModifiers() & Modifier.STATIC) == 0));

however as per the issue description this warning output is not applicable only to interface.
So, it would be appropriate to write

LOGGER.log( clazz.isInterface() ? Level.FINE : Level.WARNING,
                    LocalizationMessages.CDI_NON_INSTANTIABLE_COMPONENT(clazz));

Correct, nice catch.

[mkarg]

Thanks a lot for having this fixed! 👍 🚀