Jetty synchronous max buffer size property #4677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes #4646 |
…fer size. If property is not set, the old code path is used and exception is thrown for large responses (bigger than 2MiB). This addresses the immediate paint point and is least invasive. Exception is still thrown if response size is too big even for the custom size. Since this behaviour differs from async path it might be a good idea to just replace it completely in some major release. Signed-off-by: Klemen Ferjancic <cen.is.imba@gmail.com>
cen1
force-pushed
the
feature/jettyConfReadBuffer
branch
from
7acfdca to
dfd5080
Compare
Contributor
|
I like the PR. Would you mind updating the copyright year to 2021 in the modified files? |
Signed-off-by: Klemen Ferjancic <cen.is.imba@gmail.com>
jansupol
approved these changes
Jan 14, 2021
senivam
approved these changes
Jan 14, 2021
This was referenced Jun 26, 2021
Merged
This was referenced Jul 6, 2021
This was referenced Aug 5, 2021
This was referenced Aug 30, 2021
This was referenced Oct 19, 2022
Closed
1 task
This was referenced Feb 11, 2023
Closed
1 task
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
1 task
This was referenced Apr 13, 2024
1 task
This was referenced Feb 23, 2025
1 task
This was referenced May 26, 2025
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new jetty specific client property to set the max response buffer size. If property is not set, the old code path is used and exception is thrown for large responses (bigger than 2MiB).
This addresses the immediate paint point and is least invasive. Exception is still thrown if response size is too big even for the custom size. Since this behaviour differs from async path it might be a good idea to just
replace it completely in some major release.