Skip to content

Conversation

@mdurawa
Copy link
Contributor

@mdurawa mdurawa commented May 15, 2018

Using java.util.Base64 instead of core-common.src.main.java.org.glassfish.jersey.internal.util.Base64 allows to encode and decode characters > ASCII 127 (e. g. German umlauts).

@srbala
Copy link

srbala commented May 16, 2018

@mdurawa Add test method to validate #3803 issue.

@mdurawa
Copy link
Contributor Author

mdurawa commented May 17, 2018

@srbala the tests are already there.
I updated core-common/src/test/java/org/glassfish/jersey/internal/util/Base64Test.java (it's the test class for the deleted class - maybe that could be marked as deprecated and removed in a future release):

As mentioned in the issue these tests checked that non Ascii 127 characters are not supported, I don't know the reason for this. Now they are fine with those characters/bytes.

  • testRoundtripOneByteGreaterThan127()
  • testRoundtripAssortedValues()
  • testEncodeByteArray()

@jansupol
Copy link
Contributor

I am not sure why the IP validation check did not take place here, but I do not see the sign-off. Can you please resubmit with -s ? Otherwise it looks good. Thanks

mdurawa added 5 commits June 4, 2018 06:32
….Base64 with java.util.Base64

Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
….Base64 with java.util.Base64

Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
@mdurawa
Copy link
Contributor Author

mdurawa commented Jun 4, 2018

After some error messages on the client side, the sign-off message seems to be in the repository.

mdurawa added 3 commits June 7, 2018 13:01
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
@mdurawa
Copy link
Contributor Author

mdurawa commented Jun 8, 2018

How can I fix the test of e2e-entity?
I get the same error with a clean copy of the project master.

@jansupol jansupol merged commit eafb9bd into eclipse-ee4j:master Jun 26, 2018
agherardi pushed a commit to agherardi/jersey-1 that referenced this pull request Jul 5, 2018
…ipse-ee4j#3829)

* Replaced core-common.src.main.java.org.glassfish.jersey.internal.util.Base64 with java.util.Base64
* fixed conversion to String after decoding of Base64 encode message
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants