-
Notifications
You must be signed in to change notification settings - Fork 369
Replaced internal Base64 by java.util.Base64 (#3803) #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
….Base64 with java.util.Base64
|
@srbala the tests are already there. As mentioned in the issue these tests checked that non Ascii 127 characters are not supported, I don't know the reason for this. Now they are fine with those characters/bytes.
|
|
I am not sure why the IP validation check did not take place here, but I do not see the sign-off. Can you please resubmit with -s ? Otherwise it looks good. Thanks |
….Base64 with java.util.Base64 Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
….Base64 with java.util.Base64 Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
|
After some error messages on the client side, the sign-off message seems to be in the repository. |
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
|
How can I fix the test of e2e-entity? |
…ipse-ee4j#3829) * Replaced core-common.src.main.java.org.glassfish.jersey.internal.util.Base64 with java.util.Base64 * fixed conversion to String after decoding of Base64 encode message Signed-off-by: Michael Durawa <michael.durawa@boehringer-ingelheim.com>
Using java.util.Base64 instead of core-common.src.main.java.org.glassfish.jersey.internal.util.Base64 allows to encode and decode characters > ASCII 127 (e. g. German umlauts).