-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick Inject EntityManager changes from 8.0-JDK17 #25213
Conversation
SCOOPE to SCOPE (1/2)
SCOOPE to SCOPE (2/2)
Fix QUALIFIER and setScope
Fix QUALIFIER
This is to take into account entity manager is now injected by default.
Looks good. When compared with the 8.0-JDK17 branch, the differences are really only about Java version and some minor things that are not compatible with JDK17: https://github.com/eclipse-ee4j/glassfish/compare/8.0-JDK17..arjantijms:glassfish:8.0 There's one missing thing though - the default-web.xml file in the 8.0 branch has @arjantijms , can you also change the JDK versions in the |
That's probably a "new" feature that wasn't introduced by the merge or the EntityManager changes, but just something we did in JDK 17 branch and never did in the regular branch. I'll change it though. |
The commits were initially done on the wrong branch