Better control over System.properties

[dmatej]

General issue

• System.properties are accessed on many places in GlassFish code
• The state is global, but we don't have consistent well defined management for it.
• Server should set anything global immediately after startup and never touch it again.

Example: ServerEnvironmentImpl

• it's postConstruct method is called when it is used for the first time - then it calls System.setProperty, so services using them before it are not affected.
• it affects some automatic tests, see FIXME in UpgradeTest (will be pushed soon TODO add reference)

Example: SystemPropertyConstants and Constants and ...

• I mean com.sun.enterprise.glassfish.bootstrap.Constants, because there is around 30 classes of same name on classpath
• partially duplicated, can be simplified?
• use fulltext search to find other

[github-actions]

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

[github-actions]

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

[github-actions]

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

[OndroMih]

@dmatej, @avpinchuk , do you think that the issue with ServerEnvironmentImpl could be simply solved by adding the @RunLevel(value = InitRunLevel.VAL, mode=RunLevel.RUNLEVEL_MODE_NON_VALIDATING) annotation on the class to start it at the init run level?

[OndroMih]

Or maybe even @RunLevel(RUNLEVEL_VAL_IMMEDIATE), which should start the service immediately?