Skip to content

Fix TCK failures #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 19, 2022
Merged

Fix TCK failures #8

merged 8 commits into from
Apr 19, 2022

Conversation

@arjantijms
Copy link
Contributor

@arjantijms arjantijms commented Apr 13, 2022

Fixing 9 TCK failures:

com/sun/ts/tests/el/api/jakarta_el/methodexpression/ELClient.java#methodExpressionMatchingAmbiguousTest_from_standalone
com/sun/ts/tests/el/api/jakarta_el/methodexpression/ELClient.java#methodExpressionMatchingCoercionBeatsExactVarArgsTest_from_standalone
com/sun/ts/tests/el/api/jakarta_el/methodexpression/ELClient.java#methodExpressionMatchingExactPreferredTest_from_standalone
com/sun/ts/tests/el/api/jakarta_el/methodexpression/ELClient.java#methodExpressionMatchingOverloadBeatsCoercionTest_from_standalone
com/sun/ts/tests/el/api/jakarta_el/methodexpression/ELClient.java#methodExpressionMatchingOverloadBeatsExactVarArgsTest_from_standalone
com/sun/ts/tests/el/api/jakarta_el/methodexpression/ELClient.java#methodExpressionMatchingVarArgsTest_from_standalone
com/sun/ts/tests/el/api/jakarta_el/methodreference/ELClient.java#methodReferenceTest_from_standalone
com/sun/ts/tests/el/spec/coercion/ELClient.java#elCoerceLambdaExpressionToFunctionalInterfaceTest_from_standalone
com/sun/ts/tests/el/spec/coercion/ELClient.java#elCoerceToArrayTest_from_standalone

@arjantijms
Refactoring
a9030b3 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms
methodExpressionMatchingAmbiguousTest
389cd3b 
Allow MethodInfo to be returned from getMethodInfo if expression is a
call.

Use the actual parameter values for finding a method, so coercion can be
applied if needed.
@arjantijms arjantijms added this to the 5.0.0 milestone Apr 13, 2022
@arjantijms arjantijms marked this pull request as draft April 13, 2022 23:26
@arjantijms
Support for array coercion
4d1c2cc 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms
Refactoring
4b56870 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms
Add support for coercing lambda to functional interface
645b419 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms
Add support for MethodReference
a2d3cc6 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms
Refactoring
abcbd7e 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms
Update compiler plug-in
7c364ab 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms arjantijms marked this pull request as ready for review April 19, 2022 16:38
@arjantijms arjantijms self-assigned this Apr 19, 2022
@arjantijms arjantijms mentioned this pull request Apr 19, 2022
Closed
@arjantijms
Copy link
Contributor Author

arjantijms commented Apr 19, 2022

TCK now fully passed locally:

[INFO]      [exec] [javatest.batch] ********************************************************************************
[INFO]      [exec] [javatest.batch] Number of tests completed:  350 (350 passed, 0 failed, 0 with errors)
[INFO]      [exec] [javatest.batch] Number of tests remaining:  0
[INFO]      [exec] [javatest.batch] ********************************************************************************
[INFO]      [exec] [javatest.batch] Completed running 350 tests.
[INFO]      [exec] [javatest.batch] Number of Tests Passed      = 350
[INFO]      [exec] [javatest.batch] Number of Tests Failed      = 0
[INFO]      [exec] [javatest.batch] Number of Tests with Errors = 0
[INFO]      [exec] [javatest.batch] ********************************************************************************

@arjantijms arjantijms merged commit 69cd0ae into eclipse-ee4j:master Apr 19, 2022
@arjantijms arjantijms deleted the fixtckfailures branch April 19, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arjantijms arjantijms

Labels

None yet

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@arjantijms