Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 503 error if url contains ':' #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zistrong
Copy link

the url from attributeValue does not replace ':'. It will cause 503 error.

image

btw: use replace method for performance..

@arjantijms
Copy link
Contributor

Thanks for your contribution. Do you have an example of the kind of URL that triggers this?

@zistrong
Copy link
Author

zistrong commented Jan 3, 2024

Thanks for your contribution. Do you have an example of the kind of URL that triggers this?

https://lon1.domainname.com:8443/angular-web/schedule/(popup_window:listEmployee)
this is an angular url.

@arjantijms
Copy link
Contributor

Thanks for your contribution. Do you have an example of the kind of URL that triggers this?

https://lon1.domainname.com:8443/angular-web/schedule/(popup_window:listEmployee) this is an angular url.

Thanks for the example. Should that URL not be encoded in the first place? The ":" should not be legal in a path name, should it?

@arjantijms
Copy link
Contributor

p.s. that said, even though not being entirely legal, it does appear in the wild. E.g.

https://en.wikipedia.org/wiki/Template:Welcome

@zistrong
Copy link
Author

if I encode the url , for example: https://lon1.domainname.com:8443/angular-web/schedule/(popup_window%3AlistEmployee),
It is still illegal in glassfish7.x. it works well in glassfish5.x.

@zistrong
Copy link
Author

in glassfish-7.0.12 this bug has been fixed. close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants