feat: add toggle button to show/hide Monaco editor (#206)#209
feat: add toggle button to show/hide Monaco editor (#206)#209Pranav-0440 wants to merge 2 commits intoeclipse-editdor:masterfrom
Conversation
Signed-off-by: Pranav-0440 <pranavghorpade61@gmail.com>
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR adds a toggle button in the application header to show/hide the Monaco JSON editor, replacing the previous floating button implementation.
Changes:
- Added a toggle button with Eye/EyeOff icons in the header next to Settings
- Modified the layout to conditionally render the Monaco editor and resize bar based on visibility state
- Changed the default editor visibility from hidden to visible
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/App/AppHeader.tsx | Added Eye/EyeOff icons import, updated component props to accept toggle handler and visibility state, added toggle button in header |
| src/App.tsx | Changed default editor visibility to true, removed floating toggle button and related imports, updated layout to conditionally render editor and resize bar, passed toggle props to AppHeader |
Signed-off-by: Pranav-0440 <pranavghorpade61@gmail.com>
|
Hi @TejInaco, |
|
Tested the changes: After you clicked on hide, and click again, and the Json Editor appears, the functionality of move the vertical bar, the one that splits the two views, disappears, it remains fixed and the user is no long able to move it in order to increase or decrease the views. @Pranav-0440 see if you can understand why. |
Summary
This PR implements a toggle button to show/hide the Monaco JSON editor as requested in #206.
Changes
Behavior
Screenshots
Editor Visible :
Editor Hidden :
Testing
npm run build)