Add CSV validation warnings and example CSV files#195
Add CSV validation warnings and example CSV files#195Pranav-0440 wants to merge 5 commits intoeclipse-editdor:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a warning-collecting CSV parsing path and documents example CSV inputs to help users spot “wrong-but-parseable” CSV values (Issue #134).
Changes:
- Extend
parseCsvto return{ data, warnings }and add basic validations fortypeandmodbus:entity. - Surface CSV warnings in the CSV import flow (
CreateTd) and add examplevalid.csv/invalid.csvfiles plus README. - Add/adjust tests for the new parse result shape and validation behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/parser.ts |
Returns parsed CSV data plus validation warnings for select fields. |
src/utils/parser.test.ts |
Updates tests for the new return shape and adds warning assertions. |
src/components/App/CreateTd.tsx |
Displays CSV warnings after import (currently via error state/dialog). |
src/components/Dialogs/ConvertTmDialog.tsx |
Large refactor unrelated to CSV import; currently introduces a TM→TD conversion regression and misleading copy. |
test/csv-examples.test.ts |
Adds a “test” file for example CSVs, but currently contains no actual Vitest tests/assertions. |
doc/examples/csv/valid.csv |
Adds a “known-good” CSV example. |
doc/examples/csv/invalid.csv |
Adds an “intentionally invalid” CSV example to trigger warnings. |
doc/examples/csv/README.md |
Documents the examples and warning expectations (currently inconsistent). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Pranav-0440 <pranavghorpade61@gmail.com>
4b0e4d0 to
2447d9f
Compare
Signed-off-by: Pranav-0440 <pranavghorpade61@gmail.com>
|
I’ve cleaned up the PR to reduce unrelated diffs by resetting to origin/master and cherry-picking only the CSV validation commit. Please let me know if any further adjustments are needed. |
Yes, you did. But you didn't implemented the changes requested by the code reviews. Change to draft until changes are committed. |
Signed-off-by: Pranav-0440 <pranavghorpade61@gmail.com>
Signed-off-by: Pranav-0440 <pranavghorpade61@gmail.com>
|
Thanks @TejInaco for marking it draft.
Marking the PR ready for review again. Please let me know if anything else needs adjustment. |
|
You still have pending reviews @Pranav-0440 to be done. Return to draft. |
Pranav-0440
left a comment
There was a problem hiding this comment.
@TejInaco - All review threads have now been addressed and resolved.
Please let me know if anything further needs adjustment.
|
@TejInaco Thanks for the feedback. I’ve cleaned the branch and removed all unrelated changes (external files, documentation, and example CSV files).
Please let me know if any further adjustments are needed. |
There was a problem hiding this comment.
I didn't say to remove those files. Do a test folder inside utils to have your example of valid csv and invalid csv. Add more test to read from these files and try to find more edge cases on unit test. Mark the pending reviews as soon as you read them
| @@ -1,17 +1,31 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
| * | |||
There was a problem hiding this comment.
Copyright is not to be deleted. Revert these changes
…tures Signed-off-by: Pranav-0440 <pranavghorpade61@gmail.com>
d2ddea5 to
2afb413
Compare
|
@TejInaco I restored the original license header and reverted unrelated changes. |


Fixes - #134