Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply polymorphic to Dataset for serde #4362

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

Fixes serialization/deserialization of Catalog by applying Polymorphic to Dataset

Why it does that

bug fix

@wolf4ood wolf4ood self-assigned this Jul 15, 2024
@wolf4ood wolf4ood added the bug Something isn't working label Jul 15, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (7f20ba5) to head (22777d7).
Report is 357 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4362      +/-   ##
==========================================
+ Coverage   71.74%   74.88%   +3.14%     
==========================================
  Files         919     1063     +144     
  Lines       18457    21323    +2866     
  Branches     1037     1169     +132     
==========================================
+ Hits        13242    15968    +2726     
- Misses       4756     4832      +76     
- Partials      459      523      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood merged commit 4ca4906 into eclipse-edc:main Jul 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants