feat: implement data-plane un-registration #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
enhancement
ndr-brt
requested review from
paullatzelsperger,
bscholtes1A and
jimmarino
as code owners
wolf4ood
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Make
data-plane-self-registrationextension to un-register itself at shutdown.Why it does that
data plane management
Further notes
mapEmptyandmapFailuretoAbstractResult, they do the same thing but with a different semantic. The existingmapTomethods onResulthave been deprecated.Linked Issue(s)
Closes #4191
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.