-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/msg api improvements #2046
Merged
KerstinKeller
merged 16 commits into
eclipse-ecal:master
from
KerstinKeller:feature/msg-api-improvements
Mar 3, 2025
Merged
Feature/msg api improvements #2046
KerstinKeller
merged 16 commits into
eclipse-ecal:master
from
KerstinKeller:feature/msg-api-improvements
Mar 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Dynamic)Message subscribers do not inherit from CSubscriber.
Add testcases for capnproto. Split core related and unrelated message functionality.
hannemn
reviewed
Feb 26, 2025
serialization/capnproto/capnproto/include/ecal/msg/capnproto/publisher.h
Outdated
Show resolved
Hide resolved
6 tasks
hannemn
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework the general
CMessagePublisher
/CMessageSubscriber
.Both classes no longer inherit from
CPublisher
/CSubscriber
All serialization frameworks need to implement a generic
Serializer
class, which then allows them to easily support all of eCALs framework.String:
templatized
.type=string
,encoding=utf8
.Flatbuffers:
CObjectPublisher
,CObjectSubscriber
andCFlatSubscriber
Protobuf:
In a following PR, these Serializer classes will be used to support Measurement read / write access.