Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] improved nanopb generation #1766

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[core] improved nanopb generation #1766

merged 1 commit into from
Oct 11, 2024

Conversation

rex-schilasky
Copy link
Contributor

Description

  • generated nanopb file reorganized into the same folder structure like the source proto files
  • file extensions changed from .pb.h and .pb.c to .npb.h and .npb.c (to avoid include issues with protoc generated files)
  • simple python helper script added to generate nanopb files on windows platform

@rex-schilasky
nanopb creation scripts added
4357304 
generated nanopb files renamed and moved to another target folder
nanopb version 0.4.9 used (0.4.8 before)
@rex-schilasky rex-schilasky added the cherry-pick-to-NONE Don't cherry-pick these changes label Oct 11, 2024
KerstinKeller
KerstinKeller approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great that we can regenerate these files now automatically.

@rex-schilasky rex-schilasky merged commit 51ed6f0 into master Oct 11, 2024
20 of 22 checks passed
@rex-schilasky rex-schilasky deleted the feature/nanopb branch October 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstinKeller KerstinKeller KerstinKeller approved these changes

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rex-schilasky @KerstinKeller