[core] Reduce allocation / deallocations necessary for Registration. #1744
Conversation
…allocating elements.
… registration sample." This reverts commit b4a5329ba7d5c13f36d4c37ea5b6356d411679dc.
… to avoid memory allocations.
Small fixes.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,180 @@ | |||
| #include <gtest/gtest.h> | |||
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include <gtest/gtest.h>
^| }; | ||
|
|
||
| // Test push_back and size functionality | ||
| TEST_F(CExpandingVectorTest, PushBackAndSize) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, PushBackAndSize) { | |
| TEST_F(CExpandingVectorTest /*unused*/, PushBackAndSize /*unused*/) { |
| } | ||
|
|
||
| // Test clear functionality | ||
| TEST_F(CExpandingVectorTest, ClearElements) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, ClearElements) { | |
| TEST_F(CExpandingVectorTest /*unused*/, ClearElements /*unused*/) { |
| } | ||
|
|
||
| // Test resize functionality | ||
| TEST_F(CExpandingVectorTest, ResizeVector) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, ResizeVector) { | |
| TEST_F(CExpandingVectorTest /*unused*/, ResizeVector /*unused*/) { |
| } | ||
|
|
||
| // Test empty() function | ||
| TEST_F(CExpandingVectorTest, EmptyFunction) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, EmptyFunction) { | |
| TEST_F(CExpandingVectorTest /*unused*/, EmptyFunction /*unused*/) { |
| } | ||
|
|
||
| // Test capacity and full_size functions | ||
| TEST_F(CExpandingVectorTest, FullSize) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, FullSize) { | |
| TEST_F(CExpandingVectorTest /*unused*/, FullSize /*unused*/) { |
| } | ||
|
|
||
|
|
||
| TEST_F(CExpandingVectorTest, Front) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, Front) { | |
| TEST_F(CExpandingVectorTest /*unused*/, Front /*unused*/) { |
| } | ||
|
|
||
| // Test back function | ||
| TEST_F(CExpandingVectorTest, Back) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, Back) { | |
| TEST_F(CExpandingVectorTest /*unused*/, Back /*unused*/) { |
| } | ||
|
|
||
| // Test front and back with an empty vector (should throw an exception) | ||
| TEST_F(CExpandingVectorTest, FrontAndBackEmptyVector) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(CExpandingVectorTest, FrontAndBackEmptyVector) { | |
| TEST_F(CExpandingVectorTest /*unused*/, FrontAndBackEmptyVector /*unused*/) { |
| using core_cpp_util_expanding_vector = CExpandingVectorTest; | ||
|
|
||
| // Test push_back and size functionality | ||
| TEST_F(core_cpp_util_expanding_vector, PushBackAndSize) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, PushBackAndSize) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, PushBackAndSize /*unused*/) { |
| } | ||
|
|
||
| // Test clear functionality | ||
| TEST_F(core_cpp_util_expanding_vector, ClearElements) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, ClearElements) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, ClearElements /*unused*/) { |
| } | ||
|
|
||
| // Test resize functionality | ||
| TEST_F(core_cpp_util_expanding_vector, ResizeVector) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, ResizeVector) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, ResizeVector /*unused*/) { |
| } | ||
|
|
||
| // Test operator[] without bounds checking | ||
| TEST_F(core_cpp_util_expanding_vector, OperatorAccess) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, OperatorAccess) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, OperatorAccess /*unused*/) { |
| } | ||
|
|
||
| // Test at() function with bounds checking | ||
| TEST_F(core_cpp_util_expanding_vector, AtFunction) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, AtFunction) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, AtFunction /*unused*/) { |
| } | ||
|
|
||
| // Test empty() function | ||
| TEST_F(core_cpp_util_expanding_vector, EmptyFunction) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, EmptyFunction) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, EmptyFunction /*unused*/) { |
| } | ||
|
|
||
| // Test capacity and full_size functions | ||
| TEST_F(core_cpp_util_expanding_vector, FullSize) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, FullSize) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, FullSize /*unused*/) { |
| } | ||
|
|
||
|
|
||
| TEST_F(core_cpp_util_expanding_vector, Front) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, Front) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, Front /*unused*/) { |
| } | ||
|
|
||
| // Test back function | ||
| TEST_F(core_cpp_util_expanding_vector, Back) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, Back) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, Back /*unused*/) { |
| } | ||
|
|
||
| // Test front and back with an empty vector (should throw an exception) | ||
| TEST_F(core_cpp_util_expanding_vector, FrontAndBackEmptyVector) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(core_cpp_util_expanding_vector, FrontAndBackEmptyVector) { | |
| TEST_F(core_cpp_util_expanding_vector /*unused*/, FrontAndBackEmptyVector /*unused*/) { |
Description
In bigger, idle eCAL System there is quite a large "Grundlast" in the system, due to how Registrations are processed.
This PR tries to solve that, by providing a
Util::CExpandingVectorwhich only deallocates members upon destruction, and avoiding any unnessesary instatiations ofeCAL::Sampleinstances.