Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] Improved protobuf reflection for empty submessages #1730

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Peguen
Copy link
Contributor

@Peguen Peguen commented Sep 6, 2024

Description

Removed size check on cpp message types in protobuf reflection.

Impact: Empty message fields are visible, e.g. in eCAL monitor protobuf reflection plugin

@Peguen Peguen added the cherry-pick-to-NONE Don't cherry-pick these changes label Sep 6, 2024
Copy link
Contributor

@rex-schilasky rex-schilasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT

@rex-schilasky rex-schilasky added cherry-pick-to-support/v5.13 Cherry pick these changes to support/v5.13 and removed cherry-pick-to-NONE Don't cherry-pick these changes labels Sep 6, 2024
@Peguen Peguen merged commit b3357f2 into master Sep 9, 2024
23 of 25 checks passed
@Peguen Peguen deleted the hotfix/proto_reflection_default_submessages branch September 9, 2024 10:52
eclipse-ecal-bot pushed a commit that referenced this pull request Sep 9, 2024
…tion. (#1730)

Empty message fields are visible, e.g. in eCAL monitor protobuf reflection plugin
rex-schilasky pushed a commit that referenced this pull request Sep 9, 2024
…tion. (#1730) (#1731)

Empty message fields are visible, e.g. in eCAL monitor protobuf reflection plugin

Co-authored-by: Peguen <73380451+Peguen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-support/v5.13 Cherry pick these changes to support/v5.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants