Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for additional types in dynsub example #1776

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Support for additional types in dynsub example #1776

merged 4 commits into from
Jul 20, 2023

Conversation

dpotman
Copy link
Contributor

@dpotman dpotman commented Jul 19, 2023

This adds support for additional data types in the dynsub example (thanks @eboasson for most of the code). Additionally, the example is split into multiple files to improve readability a bit.

eboasson and others added 3 commits July 18, 2023 21:26
@eboasson @dpotman
Add support for additional data types in dynsub example
2ae86e9 
Co-authored-by: Dennis Potman <dennis@zettascale.tech>
Signed-off-by: Dennis Potman <dennis@zettascale.tech>
@dpotman
Split dynsub example into multiple files
7e538d2 
Signed-off-by: Dennis Potman <dennis@zettascale.tech>
@dpotman
Fix static analyzer issue in dynsub
1e50d47 
Signed-off-by: Dennis Potman <dennis@zettascale.tech>
@dpotman dpotman mentioned this pull request Jul 19, 2023
Closed
@dpotman dpotman changed the title Support for additional types in dynsub examaple Support for additional types in dynsub example Jul 19, 2023
@dpotman
Fix cleaning-up the type_hashid_map hash table
e06fc3e 
Signed-off-by: Dennis Potman <dennis@zettascale.tech>
eboasson
eboasson approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dpotman for taking that quick hack of mine and making it somewhat presentable. Both support for some more types and printing of the type object will come in handy in the future, I suspect.

@eboasson eboasson merged commit a1ed0ff into eclipse-cyclonedds:master Jul 20, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboasson eboasson eboasson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpotman @eboasson