In deploy_che.sh, the keycloack route should be https when the che server is https
#6739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... In `deploy_che.sh`, the keycloack route should be `https` when the che server is `https` Signed-off-by: David Festal <dfestal@redhat.com>
|
Can one of the admins verify this patch? |
benoitf
added
status/code-review
|
Can one of the admins verify this patch? |
l0rd
reviewed
Oct 13, 2017
| @@ -8,15 +8,38 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| # append_after_match allows to append content after matching line | |||
There was a problem hiding this comment.
append_after_match or append_before_match?
ghost
approved these changes
Oct 13, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows the route of the deployed dedicated keycloack server to be
httpswhen the deployed che server route ishttpsWhat issues does this PR fix or reference?
This PR fixes issue #6666