Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE: Set next development version #6692

Merged
merged 2 commits into from
Oct 14, 2017

Conversation

riuvshin
Copy link
Contributor

What does this PR do?

set next version in master

What issues does this PR fix or reference?

#6654

@codenvy-ci
Copy link

Build # 4106 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4106/ to view the results.

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Oct 12, 2017
@benoitf
Copy link
Contributor

benoitf commented Oct 12, 2017

AFAIK what I've understood in the last community meeting is that we could release 5.20 as well from the 5.x tree, not only 5.19.x versions and that it will be called a "5.x" branch

@vparfonov
Copy link
Contributor

As i remember 5.19 will be last feature release.For sure we can release 5.20 and even 5.21 if we will need but this is not our plan

@riuvshin
Copy link
Contributor Author

@benoitf we don't want to have 5.20 because next major version will be 6.
now we release 5.19.0 and temporary we set in master 5.19.1 which means NO 5.20.
after some time we will merge 6 to master. in the same time we will have 5.19.x branch for 5.x.x maintenance

@benoitf
Copy link
Contributor

benoitf commented Oct 12, 2017

the "we" was not what I've listen during the last meeting.
it was:

  • tag 5.19.0 and release it as usual in end of sprint
  • rh-che product will switch and try to use this version. We need to wait that rh-che is fully using that 5.x release branch before merging spi into master
  • once the full "rh-che/osio che/upstream" is working, a branch is created from master into 5.x and spi is merged into master

so this PR should not be limited to 5.19.1-SNAPSHOT. New development can happen (all the stuff required to have something working on OSIO, it may not be bugfixes) before it could be used on OSIO
And it's not because there is a 6.0-M1 version that there can't have any 5.x releases.

@riuvshin
Copy link
Contributor Author

riuvshin commented Oct 12, 2017

@benoitf
I think you've misunderstanded

  • yes we will release 5.19.0 as usual
  • yes rh-che will be able to use that new tag AND we will keep 5.19.x branch for it in case we will need do bugfixes but from branch not from master
    why we should block spi branch ? if don't expect new features / major changes in master after 5.19 release ?
    I could set there version 5.20.0 but we will not release 5.20.0 which will be confusing. after 5.19.0 release all releases for 5.x.x will be from branch.

@riuvshin riuvshin merged commit abe3271 into master Oct 14, 2017
@riuvshin riuvshin deleted the set_next_version_in_master_5.19.1-SNAPSHOT branch October 14, 2017 17:17
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 14, 2017
@benoitf benoitf modified the milestones: 5.19.0, 5.20.0 Oct 14, 2017
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
* RELEASE: Set next development version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants