Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some JSON RPC requests are not processed by RequestHandlerManage #5991

Merged
merged 1 commit into from
Sep 4, 2017

Conversation

dkuleshov
Copy link

Signed-off-by: Dmitry Kuleshov dkuleshov@codenvy.com

What does this PR do?

Fixes exceptions for some requests that expect result as empty elements.

What issues does this PR fix or reference?

#5542

Changelog

Fixed exceptions for requests that expect result with empty elements.

Release Notes

Fixed exceptions for requests that expect result with empty elements.

@codenvy-ci
Copy link

@musienko-maxim
Copy link
Contributor

Functional tests have passed without regression

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@@ -254,10 +254,10 @@ public void sendAndSkipResult() {
+ method
+ ", "
+ "result list items class: "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I see string concat on Logger debug while we should give object references

@@ -304,10 +304,10 @@ public void sendAndSkipResult() {
+ pValue
+ ", "
+ "result list items class: "
+ Void.class);
+ Double.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I see string concat on Logger debug while we should give object references

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem came after we had merged client and server code bases related to JSON-RPC because on client we had different logging format rules. There are many places where it is necessary to fix logging format, so I created a separate issue not to mix different kinds of changes - #6119

@codenvy-ci
Copy link

@dkuleshov dkuleshov merged commit 1f27537 into master Sep 4, 2017
@dkuleshov dkuleshov deleted the che#5542 branch September 4, 2017 09:26
kameshsampath pushed a commit to kameshsampath/che that referenced this pull request Sep 4, 2017
Some JSON RPC requests are not processed by RequestHandlerManage (eclipse-che#5991)
@slemeur slemeur added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 28, 2017
@slemeur slemeur added this to the 5.17.0 milestone Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants