-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some JSON RPC requests are not processed by RequestHandlerManage #5991
Conversation
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3370/ |
Functional tests have passed without regression |
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@@ -254,10 +254,10 @@ public void sendAndSkipResult() { | |||
+ method | |||
+ ", " | |||
+ "result list items class: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I see string concat on Logger debug while we should give object references
@@ -304,10 +304,10 @@ public void sendAndSkipResult() { | |||
+ pValue | |||
+ ", " | |||
+ "result list items class: " | |||
+ Void.class); | |||
+ Double.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I see string concat on Logger debug while we should give object references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem came after we had merged client and server code bases related to JSON-RPC because on client we had different logging format rules. There are many places where it is necessary to fix logging format, so I created a separate issue not to mix different kinds of changes - #6119
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3460/ |
Some JSON RPC requests are not processed by RequestHandlerManage (eclipse-che#5991)
Signed-off-by: Dmitry Kuleshov dkuleshov@codenvy.com
What does this PR do?
Fixes exceptions for some requests that expect result as empty elements.
What issues does this PR fix or reference?
#5542
Changelog
Fixed exceptions for requests that expect result with empty elements.
Release Notes
Fixed exceptions for requests that expect result with empty elements.