Adding sources maven artifact for dashboard-war #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun Tan <sutan@redhat.com>
benoitf
reviewed
Aug 11, 2017
dashboard/pom.xml
Outdated
| <id>add-resource</id> | ||
| <phase>generate-resources</phase> | ||
| <goals> | ||
| <goal>add-resource</goal> |
There was a problem hiding this comment.
AFAIK here you're adding sources as resources
while we should have a separated artifact including the sources.
Else we will deploy a war file that will include the source code while we're only requiring final js code
so IMHO it's more about add-source goal and using maven-source-plugin
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3340/ |
Signed-off-by: Sun Tan <sutan@redhat.com>
benoitf
approved these changes
Aug 11, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3355/ |
dmytro-ndp
pushed a commit
to dmytro-ndp/che
that referenced
this pull request
Aug 16, 2017
Adding sources maven artifact for dashboard-war Signed-off-by: Sun Tan <sutan@redhat.com>
slemeur
added
the
kind/task
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
Adding sources maven artifact for dashboard-war Signed-off-by: Sun Tan <sutan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding sources maven artifact for dashboard-war
What issues does this PR fix or reference?
Changelog
Adding sources maven artifact for dashboard-war
Release Notes
Adding sources maven artifact for dashboard-war
Docs PR