-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Che Dev Dockerfile #5959
Conversation
Dashboard now builds with docker by default so `-Pnative` needs to be set. I also made this update at [https://github.com/eclipse/che/wiki/Development-Workflow](https://github.com/eclipse/che/wiki/Development-Workflow)
Can one of the admins verify this patch? |
@james it seems eca is invalid |
Can one of the admins verify this patch? |
@benoitf What does eca stand for? What is the current eclipse policy to merge pull requests? Is it two reviews of approval before merge? Currently it allows me to merge after one review(you) but I want to make sure I am following policy. |
Eca is signing pull requests: https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=598b6e9cb0674 And yes we should wait another reviewer |
@benoitf Thanks for pointing that out. I added this to the conversation. |
Dashboard now builds with docker by default so `-Pnative` needs to be set. I also made this update at [https://github.com/eclipse/che/wiki/Development-Workflow](https://github.com/eclipse/che/wiki/Development-Workflow) Signed-off-by: James Drummond james@devcomb.com
Dashboard now builds with docker by default so
-Pnative
needs to be set. I also made this update at https://github.com/eclipse/che/wiki/Development-WorkflowSigned-off-by: James Drummond james@devcomb.com