Create routes in openshift with the same pattern than the urls provided by naming strategy #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by the naming strategy. Also it will be able to handle service name described through labels on Docker image. It means that for one image 8080 port can be tomcat, but for another image it can be named "vertx" or default value if not specified Change-Id: Ie8e0a09d0be8f6d042f542a76c146e2bbe266fc7 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
benoitf
added
kind/bug
davidfestal
approved these changes
Aug 2, 2017
ibuziuk
approved these changes
Aug 2, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3257/ |
l0rd
approved these changes
Aug 2, 2017
| * the mapping for known port labels | ||
| * @param exposedPorts | ||
| * the ports that are exposed | ||
| * @return |
There was a problem hiding this comment.
I think you forgot to specify what's returned in the javadoc
… provided by the naming strategy. Also it will be able to handle service name described through labels on Docker image. Change-Id: Ic2d2b7666d7485869ad1b4836c79dd04ff0115ed Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
benoitf
removed
the
status/code-review
benoitf
added a commit
that referenced
this pull request
Aug 3, 2017
…ed by naming strategy (#5879) * Create routes in openshift with the same pattern than the urls provided by the naming strategy. Also it will be able to handle service name described through labels on Docker image. It means that for one image 8080 port can be tomcat, but for another image it can be named "vertx" or default value if not specified Change-Id: Ie8e0a09d0be8f6d042f542a76c146e2bbe266fc7 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
benoitf
added a commit
that referenced
this pull request
Aug 3, 2017
…ed by naming strategy (#5879) * Create routes in openshift with the same pattern than the urls provided by the naming strategy. Also it will be able to handle service name described through labels on Docker image. It means that for one image 8080 port can be tomcat, but for another image it can be named "vertx" or default value if not specified Change-Id: Ie8e0a09d0be8f6d042f542a76c146e2bbe266fc7 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
dmytro-ndp
pushed a commit
to dmytro-ndp/che
that referenced
this pull request
Aug 16, 2017
…ed by naming strategy (eclipse-che#5879) * Create routes in openshift with the same pattern than the urls provided by the naming strategy. Also it will be able to handle service name described through labels on Docker image. It means that for one image 8080 port can be tomcat, but for another image it can be named "vertx" or default value if not specified Change-Id: Ie8e0a09d0be8f6d042f542a76c146e2bbe266fc7 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…ed by naming strategy (eclipse-che#5879) * Create routes in openshift with the same pattern than the urls provided by the naming strategy. Also it will be able to handle service name described through labels on Docker image. It means that for one image 8080 port can be tomcat, but for another image it can be named "vertx" or default value if not specified Change-Id: Ie8e0a09d0be8f6d042f542a76c146e2bbe266fc7 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For now, routes are created by "hardcoding" some name of services like "tomcat" for 8080
Then we need to add labels in each docker image to set "tomcat" service name for exposing 8080 port.
So for example we have "vertx" dockerfile exposing a "Tomcat-" url while there is no tomcat.
This PR is generating routes by taking care of labels if they're defined without hardcoding the value.
Note: once this PR is merged, we will be able to modify Dockerfile and change "tomcat" label to something more specific (or generic) for the stack.
What issues does this PR fix or reference?
redhat-developer/rh-che#92
Changelog
Create OpenShift routes according to the url naming strategy used.
Release Notes
BugFix
Docs PR
BugFix
Change-Id: Ie8e0a09d0be8f6d042f542a76c146e2bbe266fc7
Signed-off-by: Florent BENOIT fbenoit@redhat.com
example : vertx in the URL