Add implementation for 'Show message request' LS feature #5860

evidolob · 2017-08-01T07:33:03Z

What does this PR do?

Add implementation for 'Show message request' LS feature

What issues does this PR fix or reference?

#1794

Changelog

Add implementation for ShowMessage Request Language Server protocol feature

Release Notes

Add implementation for ShowMessage Request Language Server protocol feature

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

…nto showMessage

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

vparfonov · 2017-08-01T08:16:01Z

...main/java/org/eclipse/che/plugin/languageserver/ide/window/dialog/MessageDialogFooter.ui.xml

+
+    <g:HTMLPanel addStyleNames="{style.button-block}">
+    </g:HTMLPanel>
+</ui:UiBinder>


vparfonov · 2017-08-01T08:16:36Z

...ain/java/org/eclipse/che/plugin/languageserver/ide/window/dialog/MessageDialogPresenter.java

+        this.view.setDelegate(this);
+    }
+
+//    @Override


Do we need this comment code fragment?

vparfonov · 2017-08-01T08:16:58Z

...ain/java/org/eclipse/che/plugin/languageserver/ide/window/dialog/MessageDialogPresenter.java

+
+    @Override
+    public void onEnterClicked() {
+//        if (view.isOkButtonInFocus()) {


Do we need this comment code fragment?

vparfonov · 2017-08-01T08:17:44Z

...in/java/org/eclipse/che/plugin/languageserver/ide/window/dialog/MessageDialogViewImpl.ui.xml

+    <g:HTMLPanel addStyleNames="{style.content-block}" debugId="dialog-confirm">
+        <g:SimplePanel ui:field="content" addStyleNames="{style.content}"/>
+    </g:HTMLPanel>
+</ui:UiBinder>


codenvy-ci · 2017-08-01T08:24:40Z

Build # 3232 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3232/ to view the results.

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

codenvy-ci · 2017-08-01T14:01:37Z

Build # 3239 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3239/ to view the results.

tolusha · 2017-08-02T06:39:16Z

Add @author annotation where it is absent.

tsmaeder · 2017-08-02T08:35:48Z

@evidolob just wondering where the test launguage server is coming from?

benoitf · 2017-08-02T08:48:13Z

@tsmaeder AFAIK eclipse-che/che-lib#33

skabashnyuk · 2017-08-16T11:09:12Z

agents/pom.xml

+    <profiles>
+        <profile>
+            <id>test-ls</id>
+            <modules>


what are the purpose of this profile?

skabashnyuk · 2017-08-16T11:09:39Z

agents/test-ls/src/main/java/org/eclipse/che/api/agent/TestLSAgent.java

+
+/**
+ * Test Language server agent.
+ *


too many spaces.

skabashnyuk · 2017-08-16T11:09:51Z

agents/test-ls/src/main/java/org/eclipse/che/api/agent/TestLSModule.java

+import org.eclipse.che.inject.DynaModule;
+
+/**
+ *


skabashnyuk · 2017-08-16T11:11:21Z

core/che-core-api-core/src/main/java/org/eclipse/che/api/core/jsonrpc/impl/JsonRpcModule.java

+    @Provides
+    @Singleton
+    protected Gson gson() {
+        return DtoFactory.getInstance().getGson();


very strange way to bind gson

skabashnyuk · 2017-08-16T11:12:05Z

...ver/che-plugin-test-ls/src/main/java/org/eclipse/che/plugin/test/ls/inject/TestLSModule.java

+import static java.util.Arrays.asList;
+
+/**
+ *


skabashnyuk · 2017-08-16T11:12:44Z

...src/main/java/org/eclipse/che/api/languageserver/messager/ShowMessageJsonRpcTransmitter.java

+            result.complete(null);
+        }
+//        if (showMessageRequestEndpointIds.size() > 1) {
+//            result.completeExceptionally(new Exception("Can't send show message request, too meany clients"));


what is it?

skabashnyuk · 2017-08-16T11:13:00Z

...guageserver/src/main/java/org/eclipse/che/api/languageserver/registry/CheLanguageClient.java

+                LOG.info(message.getMessage());
+                break;
+            case Log:
+                LOG.debug(message.getMessage());


skabashnyuk · 2017-08-16T11:13:24Z

...api-languageserver/src/test/java/org/eclipse/che/api/languageserver/LocalTestLSLauncher.java

+import java.util.List;
+
+/**
+ *


skabashnyuk · 2017-08-16T11:14:12Z

...-languageserver/src/test/java/org/eclipse/che/api/languageserver/ShowMessageRequestTest.java

+        CompletableFuture<Pair<LanguageServer, InitializeResult>> initialize = initializer.initialize(launcher, client, "/tmp");
+        Pair<LanguageServer, InitializeResult> resultPair = initialize.get();
+        server = resultPair.first;
+        Thread.sleep(1200);


riuvshin · 2017-08-16T11:49:16Z

maven profile that affects final assembly is not acceptable solution here due to many reasons, for example how you would test tagged version if that profile is not default and should be included only for testing purposes. We have to rework this somehow to be able to enable / disable this without rebuild.

riuvshin

we should not have that profile, as we discussed that should be reworked to be configurable.

…nto showMessage Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

…is test LS enabled Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

riuvshin

please do not merge this before release 5.17.0 is done. And also please create an issue to use this test LS in QA tests

codenvy-ci · 2017-08-22T10:50:09Z

Build # 3481 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3481/ to view the results.

…nto showMessage Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com> # Conflicts: # core/che-core-api-core/src/main/java/org/eclipse/che/api/core/jsonrpc/commons/reception/ResultConfiguratorFromOne.java

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

codenvy-ci · 2017-09-04T12:30:30Z

Build # 3522 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3522/ to view the results.

riuvshin · 2017-09-04T13:07:02Z

ci-build

codenvy-ci · 2017-09-04T14:04:20Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3523/

Yevhen Vydolob added 3 commits July 20, 2017 16:39

#1794 implement 'ShowMessageRequest'

a8d3206

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

Merge branches 'master' and 'showMessage' of github.com:eclipse/che i…

0ea6a9d

…nto showMessage

#1794 add ability to use test LS

e1dac3b

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

evidolob requested review from dkuleshov, riuvshin, skabashnyuk, tolusha and vparfonov as code owners August 1, 2017 07:33

vparfonov reviewed Aug 1, 2017

View reviewed changes

#1794 remove commented code

74a7ce4

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

skabashnyuk reviewed Aug 16, 2017

View reviewed changes

dkuleshov approved these changes Aug 16, 2017

View reviewed changes

riuvshin suggested changes Aug 16, 2017

View reviewed changes

Yevhen Vydolob added 2 commits August 21, 2017 10:38

Merge branches 'showMessage' and 'master' of github.com:eclipse/che i…

77ffb9a

…nto showMessage Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

#1794 remove all 'test-ls' profile, use system variable to determine …

952ddd6

…is test LS enabled Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

vparfonov approved these changes Aug 22, 2017

View reviewed changes

riuvshin approved these changes Aug 22, 2017

View reviewed changes

tolusha approved these changes Sep 4, 2017

View reviewed changes

Yevhen Vydolob added 2 commits September 4, 2017 14:30

Merge branches 'master' and 'showMessage' of github.com:eclipse/che i…

d644ddc

…nto showMessage Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com> # Conflicts: # core/che-core-api-core/src/main/java/org/eclipse/che/api/core/jsonrpc/commons/reception/ResultConfiguratorFromOne.java

#1794 set next version

bfbea07

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

evidolob merged commit 2e798d6 into master Sep 4, 2017

evidolob deleted the showMessage branch September 4, 2017 14:12

slemeur added this to the 5.18.0 milestone Sep 28, 2017

slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add implementation for 'Show message request' LS feature #5860

Add implementation for 'Show message request' LS feature #5860

evidolob commented Aug 1, 2017

vparfonov Aug 1, 2017

vparfonov Aug 1, 2017

vparfonov Aug 1, 2017

vparfonov Aug 1, 2017

codenvy-ci commented Aug 1, 2017

codenvy-ci commented Aug 1, 2017

tolusha commented Aug 2, 2017

tsmaeder commented Aug 2, 2017

benoitf commented Aug 2, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

skabashnyuk Aug 16, 2017

riuvshin commented Aug 16, 2017

riuvshin left a comment

riuvshin left a comment

codenvy-ci commented Aug 22, 2017

codenvy-ci commented Sep 4, 2017

riuvshin commented Sep 4, 2017

codenvy-ci commented Sep 4, 2017

Add implementation for 'Show message request' LS feature #5860

Add implementation for 'Show message request' LS feature #5860

Conversation

evidolob commented Aug 1, 2017

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenvy-ci commented Aug 1, 2017

codenvy-ci commented Aug 1, 2017

tolusha commented Aug 2, 2017

tsmaeder commented Aug 2, 2017

benoitf commented Aug 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riuvshin commented Aug 16, 2017

riuvshin left a comment

Choose a reason for hiding this comment

riuvshin left a comment

Choose a reason for hiding this comment

codenvy-ci commented Aug 22, 2017

codenvy-ci commented Sep 4, 2017

riuvshin commented Sep 4, 2017

codenvy-ci commented Sep 4, 2017