-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used Google Java Codestyle #5851
Conversation
Build # 3221 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3221/ to view the results. |
7343b9b
to
4b9dd9b
Compare
ci-build |
What about this wiki page: https://github.com/eclipse/che/wiki/Coding-Guidelines Are you also planning to extend the development workflow guide with the information in the description of the issue: https://github.com/eclipse/che/wiki/Development-Workflow#code-style ? |
@slemeur I'll revise header if this issues with @eivantsov and will provide content for https://github.com/eclipse/che/wiki/Development-Workflow#code-style. https://github.com/eclipse/che/wiki/Coding-Guidelines eventually will be removed with link to https://google.github.io/styleguide/javaguide.html |
thanks guys. |
Build # 3423 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3423/ to view the results. |
Build # 3440 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3440/ to view the results. |
What does this PR do?
In current pr I've made formatting for all Java source code with
mvn com.coveo:fmt-maven-plugin:format
. This plugin uses this Google's tool https://github.com/google/google-java-format to applyGoogle Java codestyle
to all our source code.In this pr Changes in maven parent to adapt Google java codestyle che-parent#21 I've enabled
check
phase of fmt-maven-plugin by default. So if any formatting is missing you'll seeTo fix it, you need to execute
mvn fmt:format
To help you have the same format with you tool you can reuse IntelliJ or Eclipse code format. see more https://github.com/google/google-java-format or https://google.github.io/styleguide/javaguide.html.
If IntelliJ or Eclipse plugin produces some difference with maven plugin. Maven plugin wins. It's last
Single source of truth
What issues does this PR fix or reference?
#5772
Related to
eclipse-che/che-lib#34
eclipse-che/che-parent#21
Changelog
Release Notes
Docs PR