Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used Google Java Codestyle #5851

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Used Google Java Codestyle #5851

merged 1 commit into from
Aug 18, 2017

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Jul 31, 2017

What does this PR do?

  1. In current pr I've made formatting for all Java source code with mvn com.coveo:fmt-maven-plugin:format . This plugin uses this Google's tool https://github.com/google/google-java-format to apply Google Java codestyle to all our source code.

  2. In this pr Changes in maven parent to adapt Google java codestyle che-parent#21 I've enabled check phase of fmt-maven-plugin by default. So if any formatting is missing you'll see

2017-08-01 14 27 13

To fix it, you need to execute mvn fmt:format

  1. To help you have the same format with you tool you can reuse IntelliJ or Eclipse code format. see more https://github.com/google/google-java-format or https://google.github.io/styleguide/javaguide.html.

  2. If IntelliJ or Eclipse plugin produces some difference with maven plugin. Maven plugin wins. It's last Single source of truth

What issues does this PR fix or reference?

#5772
Related to
eclipse-che/che-lib#34
eclipse-che/che-parent#21

Changelog

Release Notes

Docs PR

@codenvy-ci
Copy link

Build # 3221 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3221/ to view the results.

@skabashnyuk skabashnyuk changed the title [WIP] Used Google Java Codestyle Used Google Java Codestyle Aug 1, 2017
@skabashnyuk skabashnyuk force-pushed the formatter branch 2 times, most recently from 7343b9b to 4b9dd9b Compare August 2, 2017 12:24
@riuvshin
Copy link
Contributor

riuvshin commented Aug 2, 2017

ci-build

@eclipse-che eclipse-che deleted a comment from codenvy-ci Aug 2, 2017
@slemeur
Copy link
Contributor

slemeur commented Aug 7, 2017

What about this wiki page: https://github.com/eclipse/che/wiki/Coding-Guidelines

Are you also planning to extend the development workflow guide with the information in the description of the issue: https://github.com/eclipse/che/wiki/Development-Workflow#code-style ?

@skabashnyuk
Copy link
Contributor Author

skabashnyuk commented Aug 7, 2017

@slemeur I'll revise header if this issues with @eivantsov and will provide content for https://github.com/eclipse/che/wiki/Development-Workflow#code-style. https://github.com/eclipse/che/wiki/Coding-Guidelines eventually will be removed with link to https://google.github.io/styleguide/javaguide.html

@ghost
Copy link

ghost commented Aug 10, 2017

https://github.com/eclipse/che/wiki/Development-Workflow#code-style and https://github.com/eclipse/che/wiki/Coding-Guidelines updated

@slemeur
Copy link
Contributor

slemeur commented Aug 10, 2017

thanks guys.

@codenvy-ci
Copy link

Build # 3423 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3423/ to view the results.

@codenvy-ci
Copy link

Build # 3440 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3440/ to view the results.

@skabashnyuk skabashnyuk merged commit 5b373e6 into master Aug 18, 2017
@skabashnyuk skabashnyuk deleted the formatter branch August 18, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants