Use docker to build dashboard app. (as alternative) #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using layer for package.json and bower.json file, it saves extra time to get npm or bower dependencies Also, if dashboard files are not modified, the build is faster. it targets as well 5127 By default : "$ mvn clean install" --> use docker "$ mvn clean install -Pnative" --> use native tools Change-Id: Ia65161b58e8ae70f7799500750a3d87687e34819 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
benoitf
added
kind/task
|
Build # 3216 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3216/ to view the results. |
olexii4
approved these changes
Jul 31, 2017
…json and bower.json file, it saves extra time to get npm or bower dependencies Change-Id: I30a43ff4d9f6020feb7057f7f1958e51079c8549 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3220/ |
ashumilova
approved these changes
Aug 1, 2017
|
@benoitf can you please mention the profile option here as well : https://github.com/eclipse/che/blob/master/dashboard/README.md |
akurinnoy
approved these changes
Aug 2, 2017
…json and bower.json file, it saves extra time to get npm or bower dependencies Change-Id: Ie716ff7d34cb86f5c249ad33709b51aa6600bc24 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
|
@ashumilova done. is it ok now ? |
…json and bower.json file, it saves extra time to get npm or bower dependencies Change-Id: I7ccb4efbe1c78d57ccb9ec2fb8adacd406fc89cb Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
…json and bower.json file, it saves extra time to get npm or bower dependencies Change-Id: I66a04d2b40725f6005733259ad887fc59cf92df0 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
…json and bower.json file, it saves extra time to get npm or bower dependencies Change-Id: I9ee1af388d96a34abfdecd5cfa3d63261f4b946d Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3271/ |
ashumilova
approved these changes
Aug 3, 2017
|
As I understand we wanted use native tools by default and profile for docker. But I'm +1 on this |
|
@riuvshin yes but after thinking a log around this I was thinking that we have more ppl having docker than all the other required tools. (this is why I used docker by default) |
benoitf
removed
the
status/code-review
dmytro-ndp
pushed a commit
to dmytro-ndp/che
that referenced
this pull request
Aug 16, 2017
* Use docker to build dashboard app. By using layer for package.json and bower.json file, it saves extra time to get npm or bower dependencies Also, if dashboard files are not modified, the build is faster. it targets as well 5127 By default : "$ mvn clean install" --> use docker "$ mvn clean install -Pnative" --> use native tools Change-Id: Ia65161b58e8ae70f7799500750a3d87687e34819 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Use docker to build dashboard app. By using layer for package.json and bower.json file, it saves extra time to get npm or bower dependencies Also, if dashboard files are not modified, the build is faster. it targets as well 5127 By default : "$ mvn clean install" --> use docker "$ mvn clean install -Pnative" --> use native tools Change-Id: Ia65161b58e8ae70f7799500750a3d87687e34819 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* Use docker to build dashboard app. By using layer for package.json and bower.json file, it saves extra time to get npm or bower dependencies Also, if dashboard files are not modified, the build is faster. it targets as well 5127 By default : "$ mvn clean install" --> use docker "$ mvn clean install -Pnative" --> use native tools Change-Id: Ia65161b58e8ae70f7799500750a3d87687e34819 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use docker to build dashboard app. (as alternative)
By using layer for package.json and bower.json file, it saves extra time to get npm or bower dependencies
Also, if dashboard files are not modified, the build is faster.
it targets as well issue #5127
By default :
"$ mvn clean install" --> use docker
"$ mvn clean install -Pnative" --> use native tools
as a side note, if all files are untouched, mvn clean install of dashboard is taking less than 10 seconds instead of like 5mn+
What issues does this PR fix or reference?
#5127
Changelog
Allow to build dashboard app with docker.
Release Notes
N/A
Docs PR
N/A
Change-Id: Ia65161b58e8ae70f7799500750a3d87687e34819
Signed-off-by: Florent BENOIT fbenoit@redhat.com