Ceylon stack #5844
Ceylon stack #5844
Conversation
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| }, | ||
| { | ||
| "description": "Ceylon stack with Java, Javascript and Dart backends on CentOS.", | ||
| "creator": "David Festal", |
There was a problem hiding this comment.
Can we use creator - "ide" here?
ashumilova
added
the
kind/enhancement
| } | ||
| }, | ||
| { | ||
| "description": "Ceylon stack with Java, Javascript and Dart backends on CentOS.", |
There was a problem hiding this comment.
there is a small typo on JavaScript
| "name": "JDK" | ||
| }, | ||
| { | ||
| "version": "3.2.2", |
There was a problem hiding this comment.
based on https://github.com/eclipse/che-dockerfiles/blob/master/recipes/centos_jdk8/Dockerfile it seems it's 3.3.9
| "name": "CentOS" | ||
| }, | ||
| { | ||
| "version": "1.8.0_45", |
There was a problem hiding this comment.
I think the version is higher
Signed-off-by: David Festal <dfestal@redhat.com>
Creative Commons I think, but I've asked for formal confirmation. I'll keep you informed. |
|
@vparfonov do you need something more to be able to approve this PR (apart from the answer to the logo license question) ? |
|
@benoitf After consulting both the JBoss design team (which is the creator of the logo), and the Ceylon team), I confirm that the logo can be considered under the same license as the The good news is that this license is one of the licenses approved by Eclipse for Non-Code, Example, and Other Content: https://eclipse.org/legal/noncodelicenses.php Hope this will allow merging this PR. |
|
@davidfestal maybe you should add license as headers of the SVG |
|
ci-build |
| "problems": [], | ||
| "source": { | ||
| "type": "git", | ||
| "location": "https://github.com/davidfestal/ceylon-hello-world", |
There was a problem hiding this comment.
is that hello world should be part of https://github.com/che-samples ?
There was a problem hiding this comment.
would be great if it could. But @TylerJewell is the only member of this organization afaik.
OTH there are already quite a few samples whose git URL is from seom other place: https://github.com/tomitribe, https://github.com/kaloyan-raev, bitnami for example
There was a problem hiding this comment.
So is it required for the merge ?
There was a problem hiding this comment.
@davidfestal no no not required for the merge. I also know that there are other examples
I can create "ceylon-hello-world" for you (or fork your repository on che-samples)
There was a problem hiding this comment.
forking would be good. Or simply creating the repo if I can have write access to it.
|
Build # 3294 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3294/ to view the results. |
|
@davidfestal please be aware that build fails with: to fix this please perform |
|
@benoitf @riuvshin I added the license into the svg file + changed the sample to point to https://github.com/che-samples/ceylon-hello-world |
|
ci-build |
Signed-off-by: David Festal <dfestal@redhat.com>
|
@benoitf done |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3297/ |
|
@vparfonov do we need something else to merge ? |
|
@davidfestal he is on PTO :) |
* Add a stack for Ceylon 1.3.2 with JVM, Javascript and Dart backends Signed-off-by: David Festal <dfestal@redhat.com>
* Add a stack for Ceylon 1.3.2 with JVM, Javascript and Dart backends Signed-off-by: David Festal <dfestal@redhat.com>
What does this PR do?
It add a stack for the Ceylon language, supporting 3 backends: JVM, Javascript on Nodes, and Dart.
It also adds a Hello World sample in the
samples.jsonfile.What issues does this PR fix or reference?
This doesn't reference any issue, since it's a feature proposal.
Changelog
Add a stack to support the Ceylon language on the JVM, NodeJS and Dart ptatforms
Release Notes
Add a stack to support the Ceylon language on the JVM, NodeJS and Dart ptatforms
Docs PR