BugZilla 518578 : Let users to use .Chefile in addition to Chefile #5471
Conversation
benoitf
added
kind/enhancement
| Log.getLogger().debug('The alternate file .Chefile is present at ', this.dotCheFile); | ||
| this.cheFile = this.dotCheFile; | ||
| } catch (e) { | ||
| Log.getLogger().debug('No chefile defined, use default settings'); |
There was a problem hiding this comment.
maybe this error message can be improved now:
- chefile --> Chefile
- and maybe add the possibility to use Chefile: "No Chefile or .Chefile defined, use default settings"
|
@apupier it's not implemented by this PR. I thought that maybe it would help if there is always a winner (no error reported). Chefile was always winning over .Chefile. You think that raising an error if the two are available will be more user friendly ? (error case vs winner case) |
|
Build # 2924 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2924/ to view the results. |
I think that it is better to have the error case. it avoids the user to start modifying the wrong Chefile Anyway, I will be happy with both cases (error or winner). Just I think the error one is slightly better. |
|
@apupier I will modify the pull request to throw the error. |
|
ok updated |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2927/ |
|
I believe that the appropriate choice would be a `.chefile` as opposed to
`.Chefile` to be consistent with other systems and handling of hidden file
names. Is the implementation case sensitive?
Tyler Jewell // Dev Products // 978-884-5355
…On Tue, Jun 27, 2017 at 4:55 AM, codenvy-ci ***@***.***> wrote:
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2927/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5471 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAX9Ch0Beor3VDDWqiZMjQRRTXr35UPgks5sIO29gaJpZM4OGQJv>
.
|
|
It is case sensitive (on operating system that supports it) |
|
so should I keep .Chefile or use .chefile ( in addition to Chefie) |
|
I would prefer |
|
from an IDE point of view, the filters are on .* names so there is no difference. |
…t allows to use a hidden file format Change-Id: Ie290a4550ccbdcc9aac64cb0c3bc60ac434a2ed8 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
…file. It allows to use a hidden file format Change-Id: I0593a874ab5307e41ebf0437600fc5f4cf98f737 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
…file. It allows to use a hidden file format Change-Id: Ia598346149941fe9d8338498e6a07dd3283d8430 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
|
I've added support then to Chefile, .chefile and .Chefile |
benoitf
removed
the
status/code-review
…clipse-che#5471) * BugZilla 518578 : Let users to use .Chefile in addition to Chefile. It allows to use a hidden file format Change-Id: Ie290a4550ccbdcc9aac64cb0c3bc60ac434a2ed8 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
What does this PR do?
It allows people to have Chefile hidden by default on Unix systems (like many metadata information not related directly to the project)
What issues does this PR fix or reference?
https://bugs.eclipse.org/bugs/show_bug.cgi?id=518578
Changelog
Handle .Chefile filename in addition to Chefile
Release Notes
Handle .Chefile filename in addition to Chefile. If both files are present, an error is reported.
Docs PR
eclipse-che/che-docs#248
Change-Id: Ie290a4550ccbdcc9aac64cb0c3bc60ac434a2ed8
Signed-off-by: Florent BENOIT fbenoit@redhat.com