Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notification file for openJDK #5441

Merged
merged 1 commit into from
Jun 26, 2017
Merged

add notification file for openJDK #5441

merged 1 commit into from
Jun 26, 2017

Conversation

riuvshin
Copy link
Contributor

What does this PR do?

Add notification file for openJDK.

What issues does this PR fix or reference?

https://github.com/codenvy/planning/issues/129

Changelog

Add notification file for openJDK.

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2891/

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2900/

@TylerJewell
Copy link

LGTM - we are getting an ip-validation error. Is this because of the switch from Codenvy to Red Hat email address?

@riuvshin
Copy link
Contributor Author

I have no idea why ip-validation failed... But I think this is related to email changes. On my side I've changed email on portal.ecliplse.org, github and local git settings to redhat.

@benoitf
Copy link
Contributor

benoitf commented Jun 26, 2017

I think it's because you've edited with github UI as well as authors are
riuvshyn@redhat.com
noreply@github.com

Squashing or rebasing the branch should solve the "ip-validation" issue

@riuvshin riuvshin requested a review from benoitf June 26, 2017 11:02
@riuvshin riuvshin added this to the 5.14.0 milestone Jun 26, 2017
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2910/

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2911/

@riuvshin riuvshin merged commit 4f52716 into master Jun 26, 2017
@riuvshin riuvshin deleted the notification_files branch June 26, 2017 15:05
@slemeur slemeur added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 6, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
add notification file (eclipse-che#5441)
c3e009d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@benoitf benoitf benoitf approved these changes

@TylerJewell TylerJewell TylerJewell approved these changes

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
5.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@riuvshin @codenvy-ci @TylerJewell @benoitf @skabashnyuk @slemeur