#5311: Update JSON LS to VSCode 1.13.0 #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
|
Can one of the admins verify this patch? |
|
@evidolob + @vparfonov : Could you please give a look as you are also working on #5311. |
evidolob
approved these changes
Jun 12, 2017
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2790/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com
What does this PR do?
This is the first step of resolving #5311.
The following attachment must be uploaded to https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.json.binaries:
vscode-json-server.tar.gz
The language server integration in Che was updated to use LSP4J 0.1.2, which supports newer version of the Language Server Protocol. The aging version of the JSON language server included in Che supported an older version of the protocol.
Updating the JSON language server to a newer version resolves some of the issues:
$schemakey I have also hovering works.There are still many issues remaining that needs to be investigated somewhere in the LS integration code.
What issues does this PR fix or reference?
Regression: JSON intellisense is broken #5311
Changelog
JSON Language Server update to VSCode 1.13.0
Release Notes