Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary gwt.xml instructions #5317

Merged
1 commit merged into from
Jun 14, 2017
Merged

Remove unnecessary gwt.xml instructions #5317

1 commit merged into from
Jun 14, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2017

Since there is no need to add plugin inheritance to gwt.xml (it's auto generated) docs are misleading users.

Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
@ghost ghost requested review from vparfonov and slemeur June 9, 2017 10:36
@codenvy-ci
Copy link

Build # 2770 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2770/ to view the results.

@ghost ghost merged commit c00ae95 into master Jun 14, 2017
@ghost ghost deleted the samples_readme branch June 14, 2017 10:57
@riuvshin riuvshin added this to the 5.12.0 milestone Jun 14, 2017
riuvshin pushed a commit that referenced this pull request Jun 14, 2017
Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
@benoitf benoitf added area/doc Issues related to documentation and removed kind/docs labels Jul 9, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants