Fix NPE for junit and testng test actions. #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detail: Fix NPE in case if user open context menu in the jar nodes in the ProjectExplorer. Fix NPE when user click to RUN menu in the main toolbar in the workspace without projects. Fix NPE when user launch step into action in the java debugger which should open java files from some jar. Clean up unused injections and imports. Main goal of this pull request: fix NPE and nothing to break :) Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
|
ci-build. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2764/ |
tolusha
approved these changes
Jun 9, 2017
azatsarynnyy
approved these changes
Jun 9, 2017
slemeur
added
the
kind/bug
vparfonov
approved these changes
Jun 9, 2017
slemeur
added
the
severity/P1
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Detail: Fix NPE in case if user open context menu in the jar nodes in the ProjectExplorer. Fix NPE when user click to RUN menu in the main toolbar in the workspace without projects. Fix NPE when user launch step into action in the java debugger which should open java files from some jar. Clean up unused injections and imports. Main goal of this pull request: fix NPE and nothing to break :) Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Detail:
Fix NPE in case if user open context menu in the jar nodes in the ProjectExplorer.
Fix NPE when user click to RUN menu in the main toolbar in the workspace without projects.
Fix NPE when user launch step into action in the java debugger which should open java files from some jar and click Run menu.
Clean up unused injections and imports.
Main goal of this pull request: fix NPE and nothing to break :)
What issues does this PR fix or reference?
#5270
Changelog
Fix NPE for junit and testng test actions.
Release Notes
Fix NPE for junit and testng test actions.
Docs PR
Don't need. It's only bugfix.
Signed-off-by: Aleksandr Andrienko aandrienko@codenvy.com