Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine support to ls-php #4946

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

davidwindell
Copy link
Contributor

@davidwindell davidwindell commented Apr 27, 2017

What does this PR do?

Add's Alpine support to ls-php (the same as other agents)

Changelog

Fixed Alpine support for ls-php (the same as other agents)

Release Notes

Fixed Alpine support for ls-php (the same as other agents)

Docs PR

@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf benoitf requested review from tolusha and a user April 28, 2017 07:38
@benoitf benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Apr 28, 2017
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 28, 2017
@benoitf benoitf added this to the 5.10.0 milestone Apr 28, 2017
@benoitf
Copy link
Contributor

benoitf commented Apr 28, 2017

@davidwindell could you check the CLA /Signed-Off of the commit message so that the IP validation check become green ?
https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=5902f1a36c9d3

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLA needs to be valid

@benoitf benoitf removed this from the 5.10.0 milestone Apr 28, 2017
Signed-off-by: David Windell <david@outeredgeuk.com>
@davidwindell
Copy link
Contributor Author

@benoitf thanks, CLA signed. Any chance of tagging #4931 to 5.10.0 as well?

@benoitf benoitf requested review from slemeur and removed request for JamesDrummond June 26, 2017 10:10
@slemeur slemeur removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 26, 2017
@slemeur slemeur added this to the 5.14.0 milestone Jun 26, 2017
@slemeur slemeur merged commit e30af7c into eclipse-che:master Jun 26, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Signed-off-by: David Windell <david@outeredgeuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants