Sets CHE_WORKSPACE_ID and CHE_MACHINE_NAME in all machines started by Che #4649
Conversation
…ough CHE it is required for single port /reverse proxy strategy Change-Id: Ib2cb987e594929151de4c26b614b91d788d19869 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
added
kind/enhancement
| volumes = commonMachineSystemVolumes; | ||
| } | ||
| // register workspace ID and Machine Name | ||
| env.put(DockerInstanceRuntimeInfo.CHE_WORKSPACE_ID, workspaceId); |
There was a problem hiding this comment.
Looks like it is not covered by tests. Some tests check WORKSPACE_ID variable setting. Behavior has changed so, please, change tests.
There was a problem hiding this comment.
ah sure, I forgot to submit the test class
There was a problem hiding this comment.
@garagatyi is it ok ? when I commented I added the test class
There was a problem hiding this comment.
Can you add shouldAddMachineNameEnvVariableOnNonDevInstanceCreationFromRecipe
There was a problem hiding this comment.
@garagatyi yes, added
…ted through CHE it is required for single port /reverse proxy strategy Change-Id: Iccaf6508ac0421363e90eeb00d0a387ce74352ef Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2335/ |
…ted through CHE it is required for single port /reverse proxy strategy Change-Id: Ia7c93d3bddaaa721f2290739a8d0133e867e2565 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2347/ |
| * Environment variable that will contain Name of the machine | ||
| */ | ||
| public static final String CHE_MACHINE_NAME = "CHE_MACHINE_NAME"; | ||
|
|
There was a problem hiding this comment.
Review without grumble is not a review.
I complain about one extra line.
…ted through CHE it is required for single port /reverse proxy strategy Change-Id: I48cfa63b9ef9c2cff015428838afcecae1f9fd1e Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2351/ |
benoitf
removed
the
status/code-review
… Che (eclipse-che#4649) * Set CHE_WORKSPACE_ID and CHE_MACHINE_NAME in all machines started through CHE it is required for single port /reverse proxy strategy Change-Id: Ib2cb987e594929151de4c26b614b91d788d19869 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
it is required for single port /reverse proxy strategy
linked PR : #4440
What does this PR do?
Sets CHE_WORKSPACE_ID and CHE_MACHINE_NAME env var in all machines started by Che
What issues does this PR fix or reference?
#4440
#4361
Changelog
Sets CHE_WORKSPACE_ID and CHE_MACHINE_NAME env variables in all machines started by Che
Release Notes
Sets CHE_WORKSPACE_ID and CHE_MACHINE_NAME env variables in all machines started by Che
Docs PR
N/A
Change-Id: Ib2cb987e594929151de4c26b614b91d788d19869
Signed-off-by: Florent BENOIT fbenoit@codenvy.com