CHE-4586: Add pip3 check fro python language server #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
evidolob
approved these changes
Mar 30, 2017
vparfonov
approved these changes
Mar 30, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2333/ |
slemeur
added
kind/enhancement
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for: #4586
Some environments like Ubuntu 16.04 have python3.5 installed but pip3 is missing. An existing script that prepares env for a python language server checks only for python3.5 but not pip. As a result if the env has python3.5 but no pip, required deps are not installed, and opening .py files hangs since language server never starts due to missing pip3. The below line of script just fails:
cd ${LS_DIR} && ${SUDO} pip3 install -r ${LS_DIR}/requirements.txt