Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-4568: Move golang agents sources to satisfy best practices #4588

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

garagatyi
Copy link

@garagatyi garagatyi commented Mar 28, 2017

What does this PR do?

In golang projects code is usually placed in a root of repo/module.
In maven world code in repo/module is placed into src/main/, e.g. src/main/java or src/main/go.
This PR moves sources from folder go-agents/src/main/go into go-agents/ to satisfy common practice in golang.

What issues does this PR fix or reference?

Fixes #4568

Changelog

Move golang agents sources to satisfy golang best practices

Release Notes

Docs PR

Sources are moved from folder go-agents/src/main/go
into go-agents/
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
@garagatyi garagatyi added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Mar 28, 2017
@garagatyi garagatyi merged commit 0c49490 into eclipse-che:master Mar 28, 2017
@garagatyi garagatyi deleted the moveGoSrcs branch March 28, 2017 12:50
@codenvy-ci
Copy link

Build # 2293 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2293/ to view the results.

@JamesDrummond JamesDrummond added this to the 5.6.0 milestone Mar 30, 2017
@JamesDrummond JamesDrummond mentioned this pull request Apr 2, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
…se-che#4588)

Sources are moved from folder go-agents/src/main/go
into go-agents/
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move golang agents code to make it Golang way
5 participants