[cli] graceful stop should work with any system state #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RUNNING -> call stop and wait for system to be in READY_TO_SHUTDOWN state - READY_TO_SHUTDOWN -> do nothing(maybe print something useful) - ANY_OTHER_STATE -> wait for system to be in READY_TO_SHUTDOWN state Change-Id: I55a8b5ecb2b016d31dbbd95b8793af4952d8116b Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
added
kind/bug
JamesDrummond
approved these changes
Feb 8, 2017
|
@JamesDrummond - on anything related to CLI, you can skip over. I'll be responsible for changelog and release notes. @benoitf - do you have some various sample outputs that you can share? I think we need to update the release notes to be more explanatory. They need full paragraphs and maybe an example or two. |
|
Build # 1912 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1912/ to view the results. |
|
@TylerJewell well the output is the same in all cases. It's just that now we handle cases where remote system is not in running state. But for 99% of ppl there is also no change as it's the default case. Other cases only happen if rest API is called by something else than cli |
TylerJewell
approved these changes
Feb 8, 2017
voievodin
approved these changes
Feb 8, 2017
benoitf
removed
the
status/code-review
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
eclipse-che#4063) - RUNNING -> call stop and wait for system to be in READY_TO_SHUTDOWN state - READY_TO_SHUTDOWN -> do nothing(maybe print something useful) - ANY_OTHER_STATE -> wait for system to be in READY_TO_SHUTDOWN state Change-Id: I55a8b5ecb2b016d31dbbd95b8793af4952d8116b Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cli graceful stop should work with any system state
until now it was expecting remote state was RUNNING.
Now if state is:
What issues does this PR fix or reference?
#3988
Changelog
[cli] graceful stop work with any remote system state
Release Notes
N/A
Docs PR
N/A
Change-Id: I55a8b5ecb2b016d31dbbd95b8793af4952d8116b
Signed-off-by: Florent BENOIT fbenoit@codenvy.com