[cli] only gives -it docker run option if it was given from the command line #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand line It avoids to give the option when it was not added on the original command line and that the sub action is not requiring a terminal Also now print a warning if a terminal is given without interactive mode Change-Id: Ib76480ccf4320748a4fbc4704773b9337048ef61 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
added
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1898/ |
TylerJewell
approved these changes
Feb 7, 2017
JamesDrummond
approved these changes
Feb 7, 2017
benoitf
removed
the
status/code-review
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
… from the command line (eclipse-che#4037) It avoids to give the option when it was not added on the original command line and that the sub action is not requiring a terminal Also now print a warning if a terminal is given without interactive mode Change-Id: Ib76480ccf4320748a4fbc4704773b9337048ef61 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For now for some commands we were using "-it" while it was not given by user so it was reporting some errors.
Now, we check the current arguments.
It avoids to give the option when it was not added on the original command line and that the sub action is not requiring a terminal
Also now print a warning if a terminal is given without interactive mode
What issues does this PR fix or reference?
#4005
Changelog
[cli] only gives -it docker run option if it was given from the command line
Release Notes
N/A bugfix
Docs PR
N/A bugfix
Change-Id: Ib76480ccf4320748a4fbc4704773b9337048ef61
Signed-off-by: Florent BENOIT fbenoit@codenvy.com