CODENVY-1407: Log agent output on fail #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2017 16:38
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
garagatyi
reviewed
Jan 31, 2017
| @Override | ||
| public void launch(Instance machine, Agent agent) throws ServerException { | ||
| if (isNullOrEmpty(agent.getScript())) { | ||
| return; | ||
| } | ||
| ListLineConsumer agentLogger = new ListLineConsumer(); | ||
| LineConsumer lineConsumer = new AbstractLineConsumer() { |
There was a problem hiding this comment.
Possible, but in that case we shouldn't close CompositeLineConsumer, only agentLogger (which is part of composite consumer).
|
Can you show an example of output if ssh connection fails? |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1824/ |
tolusha
reviewed
Jan 31, 2017
| * the agent to start | ||
| * @throws ServerException | ||
| * if script execution failed | ||
| */ |
There was a problem hiding this comment.
Doc should be moved to interface.
garagatyi
reviewed
Feb 1, 2017
| /** | ||
| * Launches agent script in machine and waits until agent starts. | ||
| * The machine should be started. | ||
| * Retrieves agent's logs if its start fails. |
There was a problem hiding this comment.
As far as I can see it logs agent logs if it fails, but stores it in any case. Is it needed to add logging related logic into javadocs?
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
tolusha
approved these changes
Feb 1, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1834/ |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
CODENVY-1407: Log agent output on fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Logs agent output if it fails to start.
What issues does this PR fix or reference?
codenvy/codenvy#1407
Changelog
Add output of failed agent into tomcat logs.
Release Notes
N/A
Docs PR
N/A