-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TypeScript language server #3145
Conversation
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1091/ |
A lot of JavaDoc missed. |
What about removing
|
|
||
/** | ||
* | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty javadoc
public static String TS_LANG = "typescript"; | ||
|
||
/** Default extension for TS files */ | ||
public static String TS_EXT = "ts"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this constant is never used so may be remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's used
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1101/ |
Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1110/ |
Build # 1148 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1148/ to view the results. |
* eclipse-che#3119 add TypeScript language server Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
What does this PR do?
add TypeScript language server
What issues does this PR fix or reference?
#3119