Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TypeScript language server #3145

Merged
merged 5 commits into from
Dec 8, 2016
Merged

add TypeScript language server #3145

merged 5 commits into from
Dec 8, 2016

Conversation

evidolob
Copy link
Contributor

What does this PR do?

add TypeScript language server

What issues does this PR fix or reference?

#3119

@codenvy-ci
Copy link

@tolusha
Copy link
Contributor

tolusha commented Nov 23, 2016

A lot of JavaDoc missed.

@tolusha
Copy link
Contributor

tolusha commented Nov 23, 2016

What about removing js prefix in names?
For instance:

  • ls-typescript instead of ls-js-ts
  • org.eclipse.che.ls.typescript.binaries instead of org.eclipse.che.ls.js-ts.binaries


/**
*
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty javadoc

public static String TS_LANG = "typescript";

/** Default extension for TS files */
public static String TS_EXT = "ts";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this constant is never used so may be remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's used

@codenvy-ci
Copy link

Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
@codenvy-ci
Copy link

@codenvy-ci
Copy link

Build # 1148 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1148/ to view the results.



Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
@evidolob evidolob merged commit b48fe2d into master Dec 8, 2016
@evidolob evidolob deleted the #3119 branch December 8, 2016 14:38
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* eclipse-che#3119 add TypeScript language server
Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants