Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some files generated by m2e to .gitignore #2705

Merged
merged 3 commits into from
Oct 5, 2016

Conversation

kaloyan-raev
Copy link
Contributor

What does this PR do?

I have quite some maven-eclipse.xml and Maven_Ant_Builder.launch files listed as unstaged changes. These files are generated by the m2e Eclipse plugin and are not supposed to be committed to the Git repo.

This PR adds maven-eclipse.xml and Maven_Ant_Builder.launch to .gitignore.

PR type

  • Minor change = no change to existing features or docs

Signed-off-by: Kaloyan Raev kaloyan.r@zend.com

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
@codenvy-ci
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use *.launch for matching all eclipse IDE commands

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
@kaloyan-raev
Copy link
Contributor Author

Makes sense. Done.

@slemeur
Copy link
Contributor

slemeur commented Oct 5, 2016

+1. This PR will help contributors who want to use Eclipse IDE.

@TylerJewell TylerJewell merged commit 56e8ae5 into eclipse-che:master Oct 5, 2016
@TylerJewell
Copy link

Thanks for the contribution.

@bmicklea bmicklea added this to the 5.0.0 milestone Jan 11, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* Add some files generated by m2e to .gitignore

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>

* Ignore all .launch files

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>

* Ignore all *.launch files

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants