Remove faulty MockaHooks.afterAll() code from E2E typescript tests #22977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is removing faulty MockaHook.afterAll() code:
deleteAllWorkspacesOnFinish()
is a redundant workspace clean up after all test run, and it's producing multiple error messagesFailed to send log. Error: Item with tempId "undefined" not found
in the test execution log:Actually, E2E typescript tests have already had workspace clean up step, e.g. https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/dashboard-samples/RecommendedExtensions.spec.ts#L217:
Test run of fixed code: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/22454/console
removeTheDriver()
makes no sense at the end, IMHO, and it throws an errorNoSuchSessionError: Unable to find session
, e.g. https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/22468/consoleTest run of fixed code: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/22492/console
Functional test run: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/complex/job/latest/job/functional-tests/1355/console
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#22648
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.