[Test] Correctly patch DevSpaces sample devfiles #22187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/code-review
che-bot
added
the
target/branch
dmytro-ndp
reviewed
May 1, 2023
tests/performance/api-pod.yaml
Outdated
| @@ -30,7 +30,7 @@ spec: | |||
| value: REPLACE_PASSWORD | |||
| - name: KUBECONFIG | |||
| value: /tmp/.kube/config | |||
| image: quay.io/openshift/origin-cli | |||
| image: quay.io/sskoryk/performance | |||
There was a problem hiding this comment.
would you consider not a personal organization, but https://quay.io/repository/crw_pr/performance ?
There was a problem hiding this comment.
If quay.io/sskoryk/performance is built using tests/performance/Dockerfile, then it is a useful information for readme.md file
There was a problem hiding this comment.
Ok, I will add it.
dmytro-ndp
reviewed
May 1, 2023
| cat dwt.yaml | ||
|
|
||
| yq -y ".spec.template.components[0].container.env += $patch" dw.yaml -i | ||
| yq -y '.spec += {"routingClass": "che"}' dw.yaml -i |
There was a problem hiding this comment.
no need to do it if use DevWorkspace generator tool (issue #22149)
There was a problem hiding this comment.
For now it doesn't work correctly. Valerii said that it will work in DS 3.7.0. I need these changes to test DS 3.6.0.
dmytro-ndp
approved these changes
May 1, 2023
che-bot
removed
the
status/code-review
SkorikSergey
added a commit
that referenced
this pull request
May 2, 2023
* correctly patch sample devfiles
nallikaea
pushed a commit
to nallikaea/che
that referenced
this pull request
May 9, 2023
* correctly patch sample devfiles
nallikaea
pushed a commit
to nallikaea/che
that referenced
this pull request
Jun 6, 2023
* correctly patch sample devfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Patch sample devfiles in performance tests as we do in API tests.
What issues does this PR fix or reference?
After getting devfile yaml file from devfile-registry add next envs to dwt and dw:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.