-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SmokeTest utilizing Quarkus REST API #22085
Implement SmokeTest utilizing Quarkus REST API #22085
Conversation
@ScrewTSW : target issue #22031 mentioned https://github.com/che-incubator/quarkus-api-example, while this PR is implementing https://github.com/che-samples/quarkus-quickstarts |
9686611
to
6cadf4f
Compare
Is it a good idea to name this test sample spec as SmokeTest.spec.ts not as Quarkus.spec.ts? We can create smoke test suite or smoke test script, which can contain not just one spec file in the future. For example, if we will have another editor and will add smoke for it too. |
Editor configuration should be independent from the test cases. Previously the tests shared the name, but were split into specific folders (theia, che-code) The name of the spec is exactly what it does :D It's a smoke test for editor |
fixed |
Example execution against dogfooding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge.
PR updated, new test run exaple:
|
@@ -67,6 +61,12 @@ export class CreateWorkspace { | |||
await this.driverHelper.waitAndClick(sampleLocator, timeout); | |||
} | |||
|
|||
async startWorkspaceFromGit(factoryUrl: string, timeout: number = TimeoutConstants.TS_CLICK_DASHBOARD_ITEM_TIMEOUT): Promise<void> { | |||
Logger.debug(`CreateWorkspace.startWorkspaceUsingFactory factoryUrl: "${factoryUrl}"`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
startWorkspaceUsingFactory
> startWorkspaceFromGit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
startWorkspaceUsingFactory > importFromGitUsingUI
17292d3
to
ed39e88
Compare
Sorry, I am still thinking that "smoke" should be suite. what do you think about it, @dmytro-ndp, @musienko-maxim ? =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ed39e88
to
686c5dc
Compare
@nallikaea : about:
It would make sense in another situation. So, it's hardly ever we will have something else to add into the "smoke" test suite in new future. But Smoke test is not a regular devfiles test, so it more suitable outside "devfiles" folder. |
I suggest another solution:
if we will have more then one test specification in our smoke suite we can make changes only in this script in "che", but not in all projects using this script as PR check
|
Or if it not sample test "ImportFromGitUsingUI.spec.js" |
@nallikaea : there will be ONLY ONE SmokeTest.spec.ts per repo. Following discussion with @ScrewTSW , if we will not link smoke test with particular testing feature name, we will be able to change test scenario in future not fixing test name. That is why, IMHO, it would better to move
|
686c5dc
to
eab3edc
Compare
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
eab3edc
to
046fa18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge.
-
SmokeTest has been passed: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/7296/console
-
EmptyWorkspace has been passed: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/7297/
What does this PR do?
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
#22031
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.