Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRW-1387 use /latest instead of /7.y.z in che.properties #18822

Merged
merged 3 commits into from
Jan 19, 2021
Merged

CRW-1387 use /latest instead of /7.y.z in che.properties #18822

merged 3 commits into from
Jan 19, 2021

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Jan 18, 2021 •
edited
Loading

What does this PR do?

  • use /latest instead of 7.y.z in che.properties
  • use sed_in_place to work on linux and macos
  • make sed replacements more legible (less slash-escaping)
  • update RELEASE.md; rename set_tag_version_images_linux.sh -> set_tag_version_images.sh

Change-Id: I6f0b586e4dc561d57d7c84b24d90031678fd3558
Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1387?_sscc=t

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt
CRW-1387 use /latest instead of /7.y.z in che.properties; replace nee…
602ebed 
…d for two set_tag_version_images* scripts with a single on that works on linux and macos; update readme

Change-Id: I3eb783131dfa4741f58e384a5d5c6d35d46c81ff
Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt
rename set_tag_version_images_linux.sh -> set_tag_version_images.sh
a8f1a3c 
Change-Id: I6f0b586e4dc561d57d7c84b24d90031678fd3558
Signed-off-by: nickboldt <nboldt@redhat.com>
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 18, 2021
@nickboldt
make sed replacements more legible
a4252f6 
Change-Id: Ibe3794f8574708658fc6f3458e1c446be02f4c23
Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt nickboldt changed the title rename set_tag_version_images_linux.sh ->... CRW-1387 use /latest instead of /7.y.z in che.properties Jan 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ericwill
ericwill approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the plugins side of things

@che-bot
Copy link
Contributor

che-bot commented Jan 18, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@nickboldt
Copy link
Contributor Author

[crw-ci-test]

This was referenced Jan 19, 2021
Closed
Closed
Closed
@che-bot
Copy link
Contributor

che-bot commented Jan 19, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@nickboldt
Copy link
Contributor Author

Implied +1 from Sergii:

image

@nickboldt nickboldt merged commit 2c7b403 into master Jan 19, 2021
@nickboldt nickboldt deleted the CRW-1387 branch January 19, 2021 18:43
@nickboldt
Copy link
Contributor Author

Followed up by eclipse-che/che-release#22 in che-release overall script.

matin2199
matin2199 reviewed Jan 28, 2021
View reviewed changes
.ci/set_tag_version_images.sh
# All rights reserved. This program and the accompanying materials
# are made available under the terms of the Eclipse Public License v1.0
# which accompanies this distribution, and is available at
# http://www.eclipse.org/legal/epl-v10.html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paul

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you saying "this should have EPL v2 on it?"

@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matin2199 matin2199 matin2199 left review comments

@ericwill ericwill ericwill approved these changes

@sparkoo sparkoo Awaiting requested review from sparkoo

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickboldt @che-bot @ericwill @matin2199