Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Selenium] Stabilize OpenshiftConnector and GitSsh typescript tests #18687

Merged
merged 2 commits into from
Dec 22, 2020
Merged

[Selenium] Stabilize OpenshiftConnector and GitSsh typescript tests #18687

merged 2 commits into from
Dec 22, 2020

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

We need to stabilize next typescript tests:

  • OpenshiftConnector - not open items in Openshift Connector plugin tree. Just wait for they visibility;
  • GitSsh - wait for plugin initization before ssh key generation.

What issues does this PR fix or reference?

#18063

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. area/qe labels Dec 22, 2020
@SkorikSergey SkorikSergey self-assigned this Dec 22, 2020
@che-bot
Copy link
Contributor

che-bot commented Dec 22, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@SkorikSergey SkorikSergey marked this pull request as ready for review December 22, 2020 16:41
@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Dec 22, 2020
dmytro-ndp
dmytro-ndp approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks commonly good.

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SkorikSergey SkorikSergey merged commit ecd2d2f into master Dec 22, 2020
@SkorikSergey SkorikSergey deleted the stabilizeTSTests branch December 22, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@SkorikSergey SkorikSergey

Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkorikSergey @che-bot @dmytro-ndp