Align app, component labels in helm chart and openshift templates #18655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
che-bot
added
status/code-review
6 tasks
mmorhun
approved these changes
Dec 18, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
Sonar failure does not seem to be related to my PR in any way |
tolusha
reviewed
Dec 18, 2020
| labels: | ||
| app: che | ||
| component: che | ||
| template: che-workspace-service-account |
There was a problem hiding this comment.
Why do we need template here?
There was a problem hiding this comment.
We don't really need it but all other OpenShift templates have it, so I've added to this template as well.
tolusha
approved these changes
Dec 18, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR align labels helm and openshift templates uses for every objects.
They should be the same as Che Operator use:
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
It's done as @tolusha suggested in eclipse-che/che-docs#1749 (comment)
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.